fix: [FEATURE] Add keyboard shortcut for jump-to-search - #1134
Merged
Conversation
|
@issue-solver-bot is attempting to deploy a commit to the ritik4ever's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@bigdeen02 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
bigdeen02
marked this pull request as ready for review
August 29, 2026 10:21
Author
|
@ritik4ever Hi! This PR is open and ready for review — happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The jump-to-search keyboard shortcut feature was already fully implemented in the codebase:
App.tsx (lines 277-300): A global
keydownlistener handles the/key to focus the search input viasearchInputRef.current?.focus(). It returns early when focus is inside an INPUT, TEXTAREA, SELECT, or contentEditable element, so the shortcut doesn't interfere with normal typing.ShortcutsHelpOverlay.tsx (line 11): The
/shortcut is already listed in the SHORTCUTS array with description "Focus the search bar".Shortcut-conflict checks: A search for "conflict" in the codebase found no existing conflict-check mechanisms to update.
Since the feature was already present but untested, I added test coverage in
App.keyboard-a11y.test.tsxwith a new "jump-to-search keyboard shortcut" describe block that verifies:/from outside a text field focuses the search input/while focus is inside a text input types the character normally without re-triggering the shortcutChanged files
frontend/src/App.keyboard-a11y.test.tsxTest plan
Run the frontend test suite, specifically:
npx vitest run frontend/src/App.keyboard-a11y.test.tsxto verify the new jump-to-search shortcut tests passnpx vitest run frontend/src/ShortcutsHelpOverlay.test.tsxto verify the overlay still lists the/shortcutnpx vitest runto ensure no regressionsThis PR was created as a draft by the issue solver bot. It will remain a
draft until repository CI passes.
Closes #854